Add obfuscate_when parameter and tag_on_match failure to obfuscate processor #3509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graytaylor0
requested review from
chenqi0805,
engechas,
dinujoh,
kkondaka,
asifsmohammed,
dlvenable and
oeyh
as code owners
dlvenable
requested changes
Oct 17, 2023
| final List<Record<Event>> editedRecords = (List<Record<Event>>) objectUnderTest.doExecute(Collections.singletonList(record)); | ||
|
|
||
| assertThat(editedRecords.size(), equalTo(1)); | ||
| assertThat(editedRecords.get(0), equalTo(record)); |
There was a problem hiding this comment.
I'm not sure this is validating that the event was unmodified.
Ideally, you could verify this with verifyNoInteractions(record.getData(), but this Event is not a mock. So I think you will need another approach. You should be able to call record.getData().toMap() before doExecute.
Then you can assert:
assertThat(editedRecords.get(0).getData().toMap(), equalTo(expectedMap));
|
New PR for this here (#3544). Had this one on my |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
obfuscate_whenparameter toobfuscateprocessor to support conditionally running obfuscate on EventsCheck List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.