Correct single quote escape character in DynamoDB [#3664] #3667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r's ObjectMapper. The EnhancedDocument is escaping single quotes. Also, skip data that cannot be parsed entirely rather than silently send empty data. Resolves opensearch-project#3664. Signed-off-by: David Venable <[email protected]>
Signed-off-by: David Venable <[email protected]>
dlvenable
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
asifsmohammed and
oeyh
as code owners
dlvenable
changed the title
dlvenable
changed the title
graytaylor0
previously approved these changes
Nov 15, 2023
Signed-off-by: David Venable <[email protected]>
graytaylor0
approved these changes
Nov 15, 2023
oeyh
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds unit tests which replicate the behavior in #3664 of single quotes causing data loss. It fixes this by updating the AWS SDK to 2.21.23. We probably should update the version anyway to keep up with the latest.
This PR also adds different error handling when failures occur from parsing data that cannot work. Now the failure is logged and the error metric is incremented.
Issues Resolved
Resolves #3664
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.