Fix visibility timeout errors (#4812) #4831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Li <[email protected]>
danhli
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
KarstenSchnitter,
dlvenable and
oeyh
as code owners
kkondaka
previously approved these changes
Aug 19, 2024
|
@danhli Thanks for working on this. |
dlvenable
requested changes
Aug 19, 2024
There was a problem hiding this comment.
Overall, this change makes sense after looking closely.
Basically, it seems that we started processing the messages in order, but without the acknowledgement set, we were not changing the visibility timeout. With this change, we will have acknowledgement sets that are going to trigger the change visibility timeout while processing the messages.
| } | ||
|
|
||
| if (endToEndAcknowledgementsEnabled) { | ||
| LOG.info("Created acknowledgement sets for {} messages.", parsedMessagesToRead.size()); |
There was a problem hiding this comment.
Let's make this a debug level log. Otherwise, we'll have too many logs generated.
There was a problem hiding this comment.
OK. I will update the log level to debug.
Signed-off-by: Daniel Li <[email protected]>
|
@kkondaka I ran the following tests to validate the changes.
|
kkondaka
approved these changes
Aug 20, 2024
dlvenable
approved these changes
Aug 23, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 23, 2024
Fix visibility timeout errors (#4812) Signed-off-by: Daniel Li <[email protected]> (cherry picked from commit 910533a)
dlvenable
pushed a commit
that referenced
this pull request
Aug 23, 2024
Fix visibility timeout errors (#4812) Signed-off-by: Daniel Li <[email protected]> (cherry picked from commit 910533a) Co-authored-by: Daniel Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The change fixes the visibility timeout errors by creating acknowledgement sets for all the messages from a SQS ReceiveMessage call before additional processing.
Issues Resolved
Resolves #4812
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.