Add retry to make sure source is not shutdown when exceptions are thrown on the main thread #5029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sb2k16
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
KarstenSchnitter,
dlvenable and
oeyh
as code owners
dlvenable
requested changes
Oct 8, 2024
| @@ -116,6 +116,11 @@ public void start(final Buffer<Record<Event>> buffer) { | |||
| public void shutDown() { | |||
| LOG.info("Stop request received for Kinesis Source"); | |||
|
|
|||
| if (scheduler == null) { | |||
| LOG.info("Scheduler not initialized!!"); | |||
There was a problem hiding this comment.
Let's avoid using exclamation marks unless we really need them.
Suggested change
| LOG.info("Scheduler not initialized!!"); | |
| LOG.info("The Kinesis Scheduler was not initialized."); |
There was a problem hiding this comment.
Thanks @dlvenable . I have addressed this.
| @@ -116,6 +116,11 @@ public void start(final Buffer<Record<Event>> buffer) { | |||
| public void shutDown() { | |||
| LOG.info("Stop request received for Kinesis Source"); | |||
|
|
|||
| if (scheduler == null) { | |||
| LOG.info("Scheduler not initialized!!"); | |||
| return; | |||
There was a problem hiding this comment.
I'm a little concerned about returning in this case. It may lead to errors down the line where we don't shut down other resources.
I tend to think this could would be better off with:
if(scheduler != null) {
// shutdown
} else {
// log
}
There was a problem hiding this comment.
Thanks @dlvenable . I have addressed this.
| try { | ||
| Thread.sleep(kinesisSourceConfig.getInitializationBackoffTime().toMillis()); | ||
| } catch (InterruptedException e){ | ||
| LOG.debug("Interrupted exception!"); |
There was a problem hiding this comment.
Suggested change
| LOG.debug("Interrupted exception!"); | |
| LOG.debug("Interrupted exception."); |
…own on the main thread Signed-off-by: Souvik Bose <[email protected]>
Signed-off-by: Souvik Bose <[email protected]>
sb2k16
force-pushed
the
kinesis-bug-fix
branch
from
69ac883 to
d6e5036
Compare
dlvenable
approved these changes
Oct 9, 2024
kkondaka
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It has been observed that If the pipeline role is missing Kinesis permissions, the source throws an exception resulting in a shutdown of the pipeline.
The fix is to add retry based on 2 configurations in KinesisSource:
This should help to make sure that the pipeline is not terminated when permissions are missing. With updated permissions, the pipeline should continue to initialize and function properly.
Issues Resolved
Resolves #1082
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.