Adds a merge function on the Event interface. #5316
+75
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the fields from another Event into the current event. Contributes toward opensearch-project#5312. Signed-off-by: David Venable <[email protected]>
dlvenable
requested review from
sb2k16,
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
KarstenSchnitter and
oeyh
as code owners
san81
reviewed
Jan 14, 2025
| } | ||
| final ObjectNode otherObjectNode = (ObjectNode) otherJacksonEvent.jsonNode; | ||
|
|
||
| if(!(jsonNode instanceof ObjectNode)) { |
There was a problem hiding this comment.
probably a nit but being more explicit like this.jsonNode makes it more readable? in the first read, I was looking for a local variable called jsonNode
san81
approved these changes
Jan 14, 2025
oeyh
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a new method
mergeon theEventinterface. It will merge fields from another Event into the current Event. It only adds new values and will not remove any values. It does override existing values with any from the other Event.Issues Resolved
None
Contributes toward #5312.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.