Do not filter out objects based on last modified timestamp when delete_objects_on_read is enabled #5319
+139
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graytaylor0
requested review from
sb2k16,
chenqi0805,
engechas,
dinujoh,
kkondaka,
KarstenSchnitter,
dlvenable and
oeyh
as code owners
chenqi0805
reviewed
Jan 9, 2025
| final S3Object s3Object) { | ||
| if (previousScanTime == null) { | ||
| if (previousScanTime == null || deleteS3ObjectsOnRead) { |
There was a problem hiding this comment.
QUES: could it be ambiguous to put deleteS3ObjectsOnRead under the function context? Is it better to directly put it in the filter?
There was a problem hiding this comment.
It seems fine either way as it is directly relevant to this filter, but it could go in the filter directly
san81
approved these changes
Jan 9, 2025
chenqi0805
previously approved these changes
Jan 9, 2025
dlvenable
reviewed
Jan 9, 2025
| @@ -452,4 +455,13 @@ void getNextPartition_with_folder_partitioning_enabled_returns_the_expected_part | |||
| assertThat(resultingPartitions.stream().map(PartitionIdentifier::getPartitionKey).collect(Collectors.toList()), | |||
| containsInAnyOrder(expectedPartitionIdentifiers.stream().map(PartitionIdentifier::getPartitionKey).map(Matchers::equalTo).collect(Collectors.toList()))); | |||
| } | |||
|
|
|||
| @Test | |||
| void isLastModifiedTimeAfterMostRecentScanForBucket_returns_true_when_disable_s3_objects_on_read_is_enabled() { | |||
There was a problem hiding this comment.
This is not an ideal test because it doesn't verify the actual public behavior of the class. It's better to verify that the public methods do what you expect when this value is enabled.
There was a problem hiding this comment.
I'll create a new test
graytaylor0
force-pushed
the
S3DeleteOnRead
branch
2 times, most recently
from
933c117 to
ef84434
Compare
…e_objects_on_read is enabled Signed-off-by: Taylor Gray <[email protected]>
graytaylor0
force-pushed
the
S3DeleteOnRead
branch
from
ef84434 to
2342be0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When delete_objects_on_read is enabled, we do not need to deduplicate and filter out objects that were already processed, because we know that if the object is not deleted, then it has not been fully processed.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.