lambda processor should retry for certain class of exceptions #5320
Conversation
Signed-off-by: Srikanth Govindarajan <[email protected]>
srikanthjg
requested review from
sb2k16,
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
KarstenSchnitter,
dlvenable and
oeyh
as code owners
| */ | ||
| private static final Set<Integer> TIMEOUT_ERRORS = new HashSet<>( | ||
| Arrays.asList( | ||
| 408, // Request Timeout |
There was a problem hiding this comment.
Is this retryable category?
| if(response == null) return false; | ||
| int statusCode = response.statusCode(); | ||
| // Example logic: 429 (Too Many Requests) or 5xx => retry | ||
| return statusCode == 429 || (statusCode >= 500 && statusCode < 600); |
There was a problem hiding this comment.
why have 429 in multiple places?
| final InvokeResponse previousResponse, | ||
| final Logger LOG | ||
| ) { | ||
| int maxRetries = config.getClientOptions().getMaxConnectionRetries(); |
There was a problem hiding this comment.
Is max connection retries same as mac lambda retries? Because it is possible for a connection to be established immediately but failed due to server errors? Or are we trying to use the same config parameter for both?
There was a problem hiding this comment.
i guess it was a bad naming for that field. The corresponding field is "max_retries", i am re-using that. I hope that is ok? I think there was another school of that we should indefinitely retry, but because this is a processor i thought it is better to retry for only certain number of times. We could also keep a different config for this and have a big but finite number assigned to this as default.
Description
Categorize exceptions as retryable and non-retryable for lambda plugin.
It should retry with backoff for certain number of times.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.