Remove NOISY log from Mongo StreamAcknowledgementManager #5321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove NOISY log from Mongo StreamAcknowledgementManager. We have metric to capture when this condition occurs, so removing logs as they are noisy Signed-off-by: Dinu John <[email protected]>
dinujoh
requested review from
sb2k16,
chenqi0805,
engechas,
graytaylor0,
kkondaka,
KarstenSchnitter,
dlvenable and
oeyh
as code owners
dlvenable
approved these changes
Jan 9, 2025
Unit Test Results 2 822 files - 227 2 822 suites - 227 1h 7m 20s ⏱️ - 3m 22s For more details on these failures, see this check. Results for commit 38661b3. ± Comparison against base commit 2aa376e. ♻️ This comment has been updated with latest results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove NOISY log from Mongo StreamAcknowledgementManager. We have metric to capture when this condition occurs, so removing logs as they are noisy
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.