Restore exception behavior for backwards compatibility #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kim Pepper <[email protected]>
kimpepper
requested review from
VachaShah,
dblock,
harshavamsi,
shyim and
saimedhi
as code owners
Signed-off-by: Kim Pepper <[email protected]>
Signed-off-by: Kim Pepper <[email protected]>
|
Do we understand why these tests broke, meaning was that expected regressions? Iterate to green? |
|
Merge #243 on top of this and it should pass, right? |
kimpepper
changed the title
Signed-off-by: Kim Pepper <[email protected]>
kimpepper
force-pushed
the
fix-tests
branch
2 times, most recently
from
9f4e0ce to
5255508
Compare
Signed-off-by: Kim Pepper <[email protected]>
Signed-off-by: Kim Pepper <[email protected]>
shyim
previously approved these changes
Jan 9, 2025
Signed-off-by: Kim Pepper <[email protected]>
|
I've generated the API as a separate commit so reviewers can see the changes without the noise. |
dblock
approved these changes
Jan 9, 2025
| /** | ||
| * @deprecated in 2.3.2 and will be removed in 3.0.0. | ||
| */ | ||
| private bool $throwExceptions = false; |
There was a problem hiding this comment.
Was the old behavior true? In which case this is the wrong default.
We need something in the user guide about error handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #233 we unintentionally removed the legacy exception behaviour.
This PR:
Issues Resolved
Restores the legacy exception behaviour and throws a deprecation warning when used.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.