chore: update cross-spawn to 7.0.6 #1469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Rowe <[email protected]>
Signed-off-by: Daniel Rowe <[email protected]>
d-rowe
requested review from
AMoo-Miki,
bandinib-amzn,
ashwin-pc,
joshuarrrr and
virajsanghvi
as code owners
AMoo-Miki
approved these changes
Dec 6, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 12, 2024
* chore: update cross-spawn to 7.0.6 Signed-off-by: Daniel Rowe <[email protected]> * include cross-spawn update in changelog Signed-off-by: Daniel Rowe <[email protected]> --------- Signed-off-by: Daniel Rowe <[email protected]> (cherry picked from commit 57ba43c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
virajsanghvi
pushed a commit
that referenced
this pull request
Dec 12, 2024
* chore: update cross-spawn to 7.0.6 * include cross-spawn update in changelog --------- (cherry picked from commit 57ba43c) Signed-off-by: Daniel Rowe <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is to resolve a CVE associated with
cross-spawn-5.1.0. The package is getting pulled in frompre-commit, which hasn't had any updates since roughly 2016. The change ensures that we usecross-spawn-7.0.6across the board.I've verified there are no relevant breaking changes from v5-v7 with their changelog. The only breaking changes are to remove support for Node.js under v8.
Alternatives
We can use this as an opportunity to shift to an actively maintained git hook tool like husky. This would ensure we're using a library that gets updated regularly at the cost of a small migration effort. I went with the current approach as it seems like the pattern y'all are used to and wanted to avoid introducing a new dependencies.
Issues Resolved
Fixes
Check List
yarn lintyarn test-unitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.