Homepage layout fix #1472
Merged
Homepage layout fix #1472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kgcreative <[email protected]>
Signed-off-by: kgcreative <[email protected]>
Signed-off-by: kgcreative <[email protected]>
Signed-off-by: kgcreative <[email protected]>
kgcreative
requested review from
AMoo-Miki,
bandinib-amzn,
ashwin-pc,
joshuarrrr and
virajsanghvi
as code owners
Signed-off-by: kgcreative <[email protected]>
virajsanghvi
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
lgtm, will wait to merge to see if @AMoo-Miki has any feedback
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 12, 2024
* simplify homepage card list by replacing OuiFlex component with CSS grid Signed-off-by: kgcreative <[email protected]> * simplify layout on homepage Signed-off-by: kgcreative <[email protected]> * clean up class properties Signed-off-by: kgcreative <[email protected]> * fix lint errors Signed-off-by: kgcreative <[email protected]> * update changelog Signed-off-by: kgcreative <[email protected]> --------- Signed-off-by: kgcreative <[email protected]> (cherry picked from commit 147fd1c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
virajsanghvi
pushed a commit
that referenced
this pull request
Dec 12, 2024
* simplify homepage card list by replacing OuiFlex component with CSS grid * simplify layout on homepage * clean up class properties * fix lint errors * update changelog --------- (cherry picked from commit 147fd1c) Signed-off-by: kgcreative <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactors card layouts in OUI Documentation homepage with CSS grid for smoother responsive behavior across breakpoints
After:
https://github.com/user-attachments/assets/4fe24dbb-591a-4c5b-bb62-373008f01c86
Issues Resolved
fixes #1471
Check List
yarn lintyarn test-unitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.