Make sure query_group_hashcode is present in top_queries response in all cases #187
+17
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…all cases Signed-off-by: Siddhant Deshmukh <[email protected]>
|
I think we should move the query hash code out from attribute and combine with #159 as an "ID field" |
Signed-off-by: Siddhant Deshmukh <[email protected]>
ansjcy
approved these changes
Jan 15, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 15, 2025
…all cases (#187) * Make sure query_group_hashcode is present in top_queries response in all cases Signed-off-by: Siddhant Deshmukh <[email protected]> * Rename query_group_hashcoe to id Signed-off-by: Siddhant Deshmukh <[email protected]> --------- Signed-off-by: Siddhant Deshmukh <[email protected]> (cherry picked from commit 9810982) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe what this change achieves.
Fixes the bug where
query_group_hashcodeis not present in the top_queries response in some cases when the from request param is specified. This caused duplicate entries on the dashboard and caused all historical rows to be displayed without query_group_hashcode.Refactoring: Rename
query_hashcodetoidas a prereq for #159Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
closes #186
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.