Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Konflux configurations architecture diagram #380

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented Oct 24, 2024

Click on view file in the top-right corner of the README.md review tag to view the diagrams

@openshift-ci openshift-ci bot requested review from matzew and mgencur October 24, 2024 17:42
Copy link

openshift-ci bot commented Oct 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pierDipi
Copy link
Member Author

Copy link
Member

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
Where did you create those images? Is there a way, we could also add the "raw" file to this PR, so we could update the image later too?

@pierDipi
Copy link
Member Author

pierDipi commented Oct 25, 2024

Raw parts are backed into the image, you can just import it and work on it, excalidraw is the tool

@pierDipi pierDipi requested a review from creydr October 25, 2024 07:04
@ReToCode
Copy link
Contributor

Nice :) But 7.5 MB per Image in Git 🤷 ? Maybe cause of #380 (comment)? Or are there other things in it?

@pierDipi
Copy link
Member Author

Nice :) But 7.5 MB per Image in Git 🤷 ? Maybe cause of #380 (comment)? Or are there other things in it?

No, there is only the image PNG + metadata to recreate the original design, what's the issue with that?

@@ -45,6 +45,17 @@ Limitations:

- It is not currently possible to disable periodics per job

# Konflux

The architecture of the Konflux configuration architecture is summarized in this diagram:
Copy link
Contributor

@skonto skonto Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some more info about design decisions made, so we may iterate on in the future? For example explain a bit the diagrams and any assumptions.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can add more details soon

@ReToCode
Copy link
Contributor

No, there is only the image PNG + metadata to recreate the original design, what's the issue with that?

Seems oddly large for such a small image (draw.io) does the same and is in KB not MB. Especially if changed the git repo size grows for each revision - but anyway.

Signed-off-by: Pierangelo Di Pilato <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants