Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run make generate-release periodically and on push #507

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented Jan 15, 2025

This will prevent repositories to get out of sync with Dockerfile generate

@pierDipi pierDipi changed the title [WIP] Run make generate-release periodically [WIP] Run make generate-release periodically and on push Jan 15, 2025
@pierDipi pierDipi force-pushed the run-make-generate-release-periodically branch 2 times, most recently from 9510a68 to 3f06290 Compare January 15, 2025 14:59
@pierDipi pierDipi force-pushed the run-make-generate-release-periodically branch from 3f06290 to e9064ab Compare January 15, 2025 15:19
@pierDipi pierDipi changed the title [WIP] Run make generate-release periodically and on push Run make generate-release periodically and on push Jan 15, 2025
@pierDipi pierDipi marked this pull request as ready for review January 15, 2025 16:12
@openshift-ci openshift-ci bot requested review from aliok and skonto January 15, 2025 16:12
@pierDipi pierDipi requested a review from creydr January 15, 2025 16:14
Copy link
Member

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Jan 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 3a79d3d into openshift-knative:main Jan 15, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants