Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add workflow to apply override snapshots and create release CR PR #514

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Add workflow to apply override snapshots and create release CR PR #514

wants to merge 13 commits into from
+428 −26

Conversation

creydr
Copy link
Member

@creydr creydr commented Jan 17, 2025 •
edited
Loading

Adding a workflow which:

  • applies the override-snapshot for a given revision
  • creates a PR with the release CRs referencing this override-snapshot(s)

@openshift-ci openshift-ci bot requested review from matzew and skonto January 17, 2025 15:34
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@creydr
Copy link
Member Author

creydr commented Jan 17, 2025

/hold to wait for openshift-knative/serverless-operator#3345

@creydr creydr requested a review from pierDipi January 20, 2025 07:11
@creydr
Copy link
Member Author

creydr commented Jan 20, 2025

/unhold

@pierDipi pierDipi changed the title Add workflow to apply the latest SO override snapshots [WIP] Add workflow to apply the latest SO override snapshots Jan 21, 2025
@creydr creydr force-pushed the add-workflow-to-apply-override-snapshots branch from 8cbf7cd to 4b5e111 Compare January 22, 2025 08:49
@creydr creydr changed the title [WIP] Add workflow to apply the latest SO override snapshots [WIP] Add workflow to apply the latest SO override snapshots and create release CR PR Jan 22, 2025
@creydr creydr changed the title [WIP] Add workflow to apply the latest SO override snapshots and create release CR PR [WIP] Add workflow to apply override snapshots and create release CR PR Jan 22, 2025
@creydr creydr changed the title [WIP] Add workflow to apply override snapshots and create release CR PR Add workflow to apply override snapshots and create release CR PR Jan 23, 2025
@creydr
Copy link
Member Author

creydr commented Jan 23, 2025

@pierDipi can you recheck?

creydr
creydr commented Jan 23, 2025
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@creydr creydr requested a review from pierDipi January 23, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew Awaiting requested review from matzew

@skonto skonto Awaiting requested review from skonto

@pierDipi pierDipi Awaiting requested review from pierDipi

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@creydr @pierDipi