Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SO 1.35.0 component release CR (2nd run) #519

Conversation

creydr
Copy link
Member

@creydr creydr commented Jan 22, 2025

Same as #516 but with a release CR with another name (same .spec as in #516).
This is some preparation in case the release pipeline of #516 fails as a release pipeline can (yet) only be retriggered with a new release CR.

/hold to trigger only in case run of #516 failed

@creydr creydr marked this pull request as ready for review January 23, 2025 12:15
@openshift-ci openshift-ci bot requested review from pierDipi and rhuss January 23, 2025 12:15
@creydr creydr changed the title [DNM] Add SO 1.35.0 component release CR (possible 2nd run) [DNM] Add SO 1.35.0 component release CR (2nd run) Jan 23, 2025
@creydr creydr changed the title [DNM] Add SO 1.35.0 component release CR (2nd run) Add SO 1.35.0 component release CR (2nd run) Jan 23, 2025
@creydr
Copy link
Member Author

creydr commented Jan 23, 2025

@creydr
Copy link
Member Author

creydr commented Jan 23, 2025

/hold cancel

Copy link
Member

@cardil cardil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

This shouldn't be necessary, but apparently Konflux is forcing us to adopt such lovely practices!

Copy link

openshift-ci bot commented Jan 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, creydr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit bbaa6e7 into openshift-knative:main Jan 23, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants