Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[serverless-1.30] patch func deploy task for serverless 1.30.2 #721

Conversation

serverless-qe
Copy link

patch for func-deploy task to use midstream specific client built for 1.30.2

@openshift-ci
Copy link

openshift-ci bot commented Oct 31, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: serverless-qe
Once this PR has been reviewed and has the lgtm label, please ask for approval from matejvasek. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (serverless-1.30@013fa90). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                Coverage Diff                 @@
##             serverless-1.30     #721   +/-   ##
==================================================
  Coverage                   ?   61.14%           
==================================================
  Files                      ?       94           
  Lines                      ?    12171           
  Branches                   ?        0           
==================================================
  Hits                       ?     7442           
  Misses                     ?     4064           
  Partials                   ?      665           
Flag Coverage Δ
e2e-test 39.57% <0.00%> (?)
e2e-test-runtime-go 28.03% <0.00%> (?)
e2e-test-runtime-node 29.14% <0.00%> (?)
e2e-test-runtime-python 29.14% <0.00%> (?)
e2e-test-runtime-quarkus 29.27% <0.00%> (?)
e2e-test-runtime-springboot 28.15% <0.00%> (?)
e2e-test-runtime-typescript 29.27% <0.00%> (?)
integration-tests 50.10% <0.00%> (?)
unit-tests-macos-latest 48.34% <0.00%> (?)
unit-tests-ubuntu-latest 49.22% <0.00%> (?)
unit-tests-windows-latest 48.39% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@serverless-qe serverless-qe force-pushed the serverless-qe/func-deploy-task-serverless-v1.30.2 branch from be109c6 to fcee8e7 Compare October 31, 2023 15:12
@serverless-qe serverless-qe force-pushed the serverless-qe/func-deploy-task-serverless-v1.30.2 branch from fcee8e7 to 8073110 Compare November 1, 2023 09:17
@jrangelramos jrangelramos merged commit e7ebdff into serverless-1.30 Feb 7, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants