Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RELEASE-v1.15] Fix configuration metadata inconsistency (#15601) #1056

Conversation

skonto
Copy link

@skonto skonto commented Dec 16, 2024

What this PR does / why we need it:

  • Backports the upstream related issue.

Which issue(s) this PR fixes:

JIRA:

Does this PR needs for other branches:

YES. v1.16

Does this PR (patch) needs to update/drop in the future?:

NONE

* fix configuration reconcile loop

* rename var
@openshift-ci openshift-ci bot requested review from mgencur and rhuss December 16, 2024 09:35
@skonto
Copy link
Author

skonto commented Dec 16, 2024

/cherry-pick release-v1.16

@openshift-cherrypick-robot

@skonto: once the present PR merges, I will cherry-pick it on top of release-v1.16 in a new PR and assign it to you.

In response to this:

/cherry-pick release-v1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@skonto
Copy link
Author

skonto commented Dec 16, 2024

/assign @ReToCode

@skonto skonto requested review from ReToCode and removed request for rhuss December 16, 2024 09:39
Copy link

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Dec 16, 2024
Copy link

openshift-ci bot commented Dec 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD bc945b3 and 2 for PR HEAD 69fe8b0 in total

@skonto
Copy link
Author

skonto commented Dec 16, 2024

ci/prow/417-test-e2e-tls
Image push failed 🤷 :

Registry server Password: <<non-empty>>
error: build error: Failed to push image: trying to reuse blob sha256:e0348fdb2685077d22116d294a90a253709aba78815882a57fcc536b22dcae2f at destination: unable to retrieve auth token: invalid username/password: authentication required
10:59:43.051 INFO:    Image builds finished

ingress pod log

  Warning  Failed          4m26s (x4 over 5m52s)  kubelet            Error: ErrImagePull
  Warning  Failed          4m11s (x6 over 5m51s)  kubelet            Error: ImagePullBackOff
  Normal   BackOff         45s (x21 over 5m51s)   kubelet            Back-off pulling image "image-registry.openshift-image-registry.svc:5000/openshift-marketplace/serverless-ingress"

Installation times out:

11:06:09.404 DEBUG:   [[ $(oc get ClusterServiceVersion serverless-operator.v1.35.0 -n openshift-serverless -o jsonpath='{.status.phase}') != Succeeded ]] : Waiting until non-zero (max 300 sec.)
.............................................................................................................................................................................................................................................................................................................
11:11:42.771 ERROR:   Time out of 300 exceeded

@skonto
Copy link
Author

skonto commented Dec 16, 2024

/override ?

Copy link

openshift-ci bot commented Dec 16, 2024

@skonto: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • ?

Only the following failed contexts/checkruns were expected:

  • Red Hat Konflux / serverless-operator-135-ec / kn-serving-activator-115
  • Red Hat Konflux / serverless-operator-135-ec / kn-serving-autoscaler-115
  • Red Hat Konflux / serverless-operator-135-ec / kn-serving-autoscaler-hpa-115
  • Red Hat Konflux / serverless-operator-135-ec / kn-serving-cleanup-115
  • Red Hat Konflux / serverless-operator-135-ec / kn-serving-controller-115
  • Red Hat Konflux / serverless-operator-135-ec / kn-serving-dataplane-probe-115
  • Red Hat Konflux / serverless-operator-135-ec / kn-serving-default-domain-115
  • Red Hat Konflux / serverless-operator-135-ec / kn-serving-load-test-115
  • Red Hat Konflux / serverless-operator-135-ec / kn-serving-queue-115
  • Red Hat Konflux / serverless-operator-135-ec / kn-serving-real-traffic-test-115
  • Red Hat Konflux / serverless-operator-135-ec / kn-serving-reconciliation-delay-115
  • Red Hat Konflux / serverless-operator-135-ec / kn-serving-rollout-probe-115
  • Red Hat Konflux / serverless-operator-135-ec / kn-serving-scale-from-zero-115
  • Red Hat Konflux / serverless-operator-135-ec / kn-serving-storage-version-migration-115
  • Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-autoscale-115
  • Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-failing-115
  • Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-grpc-ping-115
  • Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-hellohttp2-115
  • Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-hellovolume-115
  • Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-helloworld-115
  • Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-httpproxy-115
  • Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-pizzaplanetv1-115
  • Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-pizzaplanetv2-115
  • Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-readiness-115
  • Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-revisionfailure-115
  • Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-runtime-115
  • Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-servingcontainer-115
  • Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-sidecarcontainer-115
  • Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-singlethreaded-115
  • Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-slowstart-115
  • Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-timeout-115
  • Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-volumes-115
  • Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-wsserver-115
  • Red Hat Konflux / serverless-operator-135-ec / kn-serving-webhook-115
  • ci/prow/417-images
  • ci/prow/417-test-e2e
  • ci/prow/417-test-e2e-tls
  • pull-ci-openshift-knative-serving-release-next-417-images
  • pull-ci-openshift-knative-serving-release-next-417-test-e2e
  • pull-ci-openshift-knative-serving-release-v1.15-417-test-e2e-tls
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@skonto
Copy link
Author

skonto commented Dec 16, 2024

/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-activator-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-autoscaler-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-autoscaler-hpa-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-cleanup-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-controller-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-dataplane-probe-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-default-domain-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-load-test-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-queue-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-real-traffic-test-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-reconciliation-delay-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-rollout-probe-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-scale-from-zero-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-storage-version-migration-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-autoscale-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-failing-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-grpc-ping-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-hellohttp2-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-hellovolume-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-helloworld-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-httpproxy-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-pizzaplanetv1-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-pizzaplanetv2-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-readiness-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-revisionfailure-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-runtime-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-servingcontainer-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-sidecarcontainer-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-singlethreaded-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-slowstart-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-timeout-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-volumes-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-wsserver-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-webhook-115"

Copy link

openshift-ci bot commented Dec 16, 2024

@skonto: Overrode contexts on behalf of skonto: Red Hat Konflux / serverless-operator-135-ec / kn-serving-activator-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-autoscaler-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-autoscaler-hpa-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-cleanup-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-controller-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-dataplane-probe-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-default-domain-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-load-test-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-queue-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-real-traffic-test-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-reconciliation-delay-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-rollout-probe-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-scale-from-zero-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-storage-version-migration-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-autoscale-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-failing-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-grpc-ping-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-hellohttp2-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-hellovolume-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-helloworld-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-httpproxy-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-pizzaplanetv1-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-pizzaplanetv2-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-readiness-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-revisionfailure-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-runtime-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-servingcontainer-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-sidecarcontainer-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-singlethreaded-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-slowstart-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-timeout-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-volumes-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-wsserver-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-webhook-115

In response to this:

/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-activator-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-autoscaler-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-autoscaler-hpa-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-cleanup-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-controller-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-dataplane-probe-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-default-domain-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-load-test-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-queue-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-real-traffic-test-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-reconciliation-delay-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-rollout-probe-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-scale-from-zero-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-storage-version-migration-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-autoscale-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-failing-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-grpc-ping-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-hellohttp2-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-hellovolume-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-helloworld-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-httpproxy-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-pizzaplanetv1-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-pizzaplanetv2-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-readiness-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-revisionfailure-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-runtime-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-servingcontainer-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-sidecarcontainer-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-singlethreaded-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-slowstart-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-timeout-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-volumes-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-wsserver-115"
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-webhook-115"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@skonto
Copy link
Author

skonto commented Dec 16, 2024

@ReToCode this still fails.

@skonto
Copy link
Author

skonto commented Dec 16, 2024

Registry server Email:
Registry server Password: <>
error: build error: Failed to push image: trying to reuse blob sha256:e0348fdb2685077d22116d294a90a253709aba78815882a57fcc536b22dcae2f at destination: unable to retrieve auth token: invalid username/password: authentication required
12:44:52.926 DEBUG: Undo potential changes to the CSV to not pollute the repository.
Warning: Group 'system:unauthenticated' not found
clusterrole.rbac.authorization.k8s.io/system:image-puller added: "system:unauthenticated"
Warning: Group 'system:serviceaccounts:openshift-serverless' not found
clusterrole.rbac.authorization.k8s.io/system:image-puller added: "system:serviceaccounts:openshift-serverless"

@skonto skonto changed the title [RELEASE-1.15] Fix configuration metadata inconsistency (#15601) [RELEASE-v1.15] Fix configuration metadata inconsistency (#15601) Dec 16, 2024
@skonto
Copy link
Author

skonto commented Dec 16, 2024

/test 417-test-e2e-tls

@skonto
Copy link
Author

skonto commented Dec 16, 2024

Another error now


: initialize expand_less	0s
{  could not initialize namespace: could not set up namespace for test: Internal error occurred: resource quota evaluation timed out}

@skonto
Copy link
Author

skonto commented Dec 16, 2024

@ReToCode I think we can override tls tests now and address this separately at the S-O side. The PR is unrelated anyway to internal encryption and normal tests do pass. wdyth?

@skonto
Copy link
Author

skonto commented Dec 16, 2024

/test 417-test-e2e-tls

1 similar comment
@skonto
Copy link
Author

skonto commented Dec 18, 2024

/test 417-test-e2e-tls

@openshift-merge-bot openshift-merge-bot bot merged commit 1dd923b into openshift-knative:release-v1.15 Dec 18, 2024
76 of 110 checks passed
@openshift-cherrypick-robot

@skonto: cannot checkout release-vX.Y: error checking out "release-vX.Y": exit status 1 error: pathspec 'release-vX.Y' did not match any file(s) known to git

In response to this:

What this PR does / why we need it:

  • Backports the upstream related issue.

Which issue(s) this PR fixes:

JIRA:

Does this PR needs for other branches:

YES. v1.16

Does this PR (patch) needs to update/drop in the future?:

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@skonto: new pull request created: #1060

In response to this:

/cherry-pick release-v1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants