-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RELEASE-v1.15] Fix configuration metadata inconsistency (#15601) #1056
[RELEASE-v1.15] Fix configuration metadata inconsistency (#15601) #1056
Conversation
* fix configuration reconcile loop * rename var
/cherry-pick release-v1.16 |
@skonto: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/assign @ReToCode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ReToCode, skonto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ci/prow/417-test-e2e-tls
Installation times out:
|
/override ? |
@skonto: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override "Red Hat Konflux / serverless-operator-135-ec / kn-serving-activator-115" |
@skonto: Overrode contexts on behalf of skonto: Red Hat Konflux / serverless-operator-135-ec / kn-serving-activator-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-autoscaler-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-autoscaler-hpa-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-cleanup-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-controller-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-dataplane-probe-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-default-domain-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-load-test-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-queue-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-real-traffic-test-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-reconciliation-delay-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-rollout-probe-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-scale-from-zero-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-storage-version-migration-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-autoscale-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-failing-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-grpc-ping-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-hellohttp2-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-hellovolume-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-helloworld-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-httpproxy-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-pizzaplanetv1-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-pizzaplanetv2-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-readiness-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-revisionfailure-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-runtime-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-servingcontainer-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-sidecarcontainer-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-singlethreaded-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-slowstart-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-timeout-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-volumes-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-test-wsserver-115, Red Hat Konflux / serverless-operator-135-ec / kn-serving-webhook-115 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@ReToCode this still fails. |
Registry server Email: |
/test 417-test-e2e-tls |
Another error now
|
@ReToCode I think we can override tls tests now and address this separately at the S-O side. The PR is unrelated anyway to internal encryption and normal tests do pass. wdyth? |
/test 417-test-e2e-tls |
1 similar comment
/test 417-test-e2e-tls |
1dd923b
into
openshift-knative:release-v1.15
@skonto: cannot checkout In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@skonto: new pull request created: #1060 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
Which issue(s) this PR fixes:
JIRA:
Does this PR needs for other branches:
YES. v1.16
Does this PR (patch) needs to update/drop in the future?:
NONE