Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RELEASE-v1.16] Update golang.org/x/crypto to 0.31.0 #1059

Merged

Conversation

skonto
Copy link

@skonto skonto commented Dec 17, 2024

What this PR does / why we need it:
See discussion here.

Which issue(s) this PR fixes:

JIRA:

Does this PR needs for other branches:

Does this PR (patch) needs to update/drop in the future?:

JIRA:

Copy link

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Dec 17, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 2d6b0e4 and 2 for PR HEAD 747f30a in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 2d6b0e4 and 2 for PR HEAD 747f30a in total

@openshift-ci openshift-ci bot removed the lgtm label Dec 18, 2024
@ReToCode
Copy link

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Dec 18, 2024
Copy link

openshift-ci bot commented Dec 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 345fef8 into openshift-knative:release-v1.16 Dec 18, 2024
93 checks passed
@openshift-cherrypick-robot

@skonto: cannot checkout release-vX.Y: error checking out "release-vX.Y": exit status 1 error: pathspec 'release-vX.Y' did not match any file(s) known to git

In response to this:

What this PR does / why we need it:
See discussion here.

Which issue(s) this PR fixes:

JIRA:

Does this PR needs for other branches:

Does this PR (patch) needs to update/drop in the future?:

JIRA:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants