Multus should look for CNI configuration in a different directory than kubelet #218
Conversation
openshift-ci-robot
added
the
size/L
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: squeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
Hmm, all the nodes came up Ready, so I don't think this caused any issues. |
|
Found the problem: |
…n kubelet. This changes Multus to look for "default" CNI configurations in a different directory than where it writes it's file for CRIO. It also updates all plugins to write to that directory (when multus is enabled).
|
/retest |
|
So can you clarify what this is changing? I thought we basically already did this... |
|
Multus implemented this option, but now we actually use it. |
|
But I could have sworn we already did this... or was that just for the CNI binaries and now this includes the conf files as well? |
CNI binaries have always been the same directory - and that doesn't change. All I recall is talking about implementing this in multus - and now we're using that feature. |
|
Interesting, looks like it's actually failing upgrade from 4.1 - taking a look. |
|
/test e2e-aws-upgrade |
|
This continuously fails upgrade. It seems that crio is somehow marking the node as NotReady, even though the CNI configuration file (from multus) is definitely on disk. Of course, restarting crio fixes it. /hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
Yeah, confirmed - there's a weird crio situation where if Of course, we're in to this situation exactly because we didn't do the right thing and relied on usually winning a race in the first place. |
|
@squeed: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Filed cri-o/ocicni#46 - let's see how that goes. |
|
@squeed: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
needs-rebase
|
closing for now (so it doesn't get accidentally merged). |
This changes Multus to look for "default" CNI configurations in a different directory than where it writes it's file for CRIO. It also updates all plugins to write to that directory (when multus is enabled).