Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-54903: upgrade showdown to fix cross-spawn on shared sdk #14678

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

upalatucci
Copy link
Contributor

@upalatucci upalatucci commented Jan 13, 2025

@openshift-console/plugin-shared uses a fixed version of showdown affected by cross-spawn CVE.

This do not fix the CVE issue in the console but at least do not propagate the issue on plugins that use @openshift-console/plugin-shared

Surely it's a step to fix the CVE on the console but it seems like we need to upgrade also jest.

The upgrade from 1.8.6 to 1.9.1 is not a big leap. They just added a new feature and fixed a couple of bugs
https://github.com/showdownjs/showdown/releases

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 13, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 13, 2025

@upalatucci: This pull request references CNV-54903 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the vulnerability to target the "4.19.0" version, but no target version was set.

In response to this:

@openshift-console/plugin-shared uses a fixed version of showdown affected by cross-spawn CVE.

This do not fix the CVE issue in console but at least do not propagate the issue on plugins that use @openshift-console/plugin-shared

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from jhadvig and Mylanos January 13, 2025 08:57
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 13, 2025

@upalatucci: This pull request references CNV-54903 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the vulnerability to target the "4.19.0" version, but no target version was set.

In response to this:

@openshift-console/plugin-shared uses a fixed version of showdown affected by cross-spawn CVE.

This do not fix the CVE issue in console but at least do not propagate the issue on plugins that use @openshift-console/plugin-shared

The upgrade from 1.8.6 to 1.9.1 is not a big leap. They just added a new feature and fixed a couple of bugs
https://github.com/showdownjs/showdown/releases

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 13, 2025

@upalatucci: This pull request references CNV-54903 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the vulnerability to target the "4.19.0" version, but no target version was set.

In response to this:

@openshift-console/plugin-shared uses a fixed version of showdown affected by cross-spawn CVE.

This do not fix the CVE issue in the console but at least do not propagate the issue on plugins that use @openshift-console/plugin-shared

Surely it's a step to fix the CVE on the console but it seems like we need to upgrade also jest.

The upgrade from 1.8.6 to 1.9.1 is not a big leap. They just added a new feature and fixed a couple of bugs
https://github.com/showdownjs/showdown/releases

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@upalatucci
Copy link
Contributor Author

/retest

1 similar comment
@upalatucci
Copy link
Contributor Author

/retest

Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2025
Copy link
Contributor

openshift-ci bot commented Jan 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2025
@upalatucci
Copy link
Contributor Author

/retest

5 similar comments
@upalatucci
Copy link
Contributor Author

/retest

@upalatucci
Copy link
Contributor Author

/retest

@upalatucci
Copy link
Contributor Author

/retest

@upalatucci
Copy link
Contributor Author

/retest

@upalatucci
Copy link
Contributor Author

/retest

Copy link
Contributor

openshift-ci bot commented Jan 21, 2025

@upalatucci: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants