Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add one more ColorMap #743

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add one more ColorMap #743

wants to merge 1 commit into from

Conversation

aymanhab
Copy link
Member

This matches with Book figure(s), use by setting preference "Muscle Color Scheme" to "Book"

Fixes issue #

Brief summary of changes

One more option for muscle coloring

Testing I've completed

Loaded states files from existing examples and got colors that match Tom's

CHANGELOG.md (choose one)

  • no need to update because new option, hidden for now

…g preference "Muscle Color Scheme" to "Book"
@chrisdembia
Copy link
Member

I'm not sure users will know what "Book" means. Are there other descriptors you and @tkuchida have been using to describe this color scheme?

@aymanhab
Copy link
Member Author

That's a good point @chrisdembia I wasn't planning on publishing this to users, but rather make it available internally to @tkuchida to tweak a little more or use for figures. If we reach a consensus we can document.

@tkuchida
Copy link
Member

I've already made the changes locally and don't plan on using this feature.

@aymanhab
Copy link
Member Author

Thanks @tkuchida
I will not merge this PR then until there's a specific need. I'll leave it open for potential future use and to show users what it takes to add a new ColorMap for muscles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants