-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update readme to include CLI #32
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@martincarapia, I have added a few suggestions. Also, please include the text Closes issue #29
in the commit body instead of the commit header.
Sorry, I forgot to mention that we need to install the
|
Your commit still contains the |
Alright fixed. Everything should be good. |
Now your PR has 7 commits. This can be fixed if you rebase your branch from the |
Rebased. |
@martincarapia, You somehow accidentally added some unnecessary commits to your branch. Consequently, your PR has four commits and two of them already exist in the main branch. I have added an image for the clarification. However, this can be fixed using an interactive rebase. Make sure your branch updates with the main branch. git fetch origin main
git rebase origin/main Once the rebase is complete, you can use the interactive rebase. git rebase -i 8761e42 where Using interactive rebase, you can delete unnecessary commits, squash two commits, reword the commits, and more. Moreover, your commit header cannot end with period ( Reference: |
Thank you for your clarification, and thank you for your patience. I'm new to all of this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Description
Update README.md to include CLI.
Related Issue
Fixes #29
Type of Change
Please mark the appropriate option below to describe the type of change your pull request introduces:
Checklist
Examples:
"fix: Fixed foobar bug"
,"feat(accounts): Added foobar feature"
.README.md
.By submitting this pull request, I confirm that I have read and complied with the contribution guidelines of this project.