Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix major version tag fetch on pre-commit autoupdate #65

Merged

Conversation

aj3sh
Copy link
Member

@aj3sh aj3sh commented Aug 12, 2024

Description

The annotated tag with a major version (e.g., v1) was created with a new timestamp. Therefore, pre-commit treated the major version tag as the latest tag.

Fix:

  • Created simple tags instead of annotated tags. Simple tags will reference the commit timestamp.
  • Removed creation of minor version 2-digit tag.

Related Issue

Relates #64

Type of Change

Please mark the appropriate option below to describe the type of change your pull request introduces:

  • Bug fix
  • New feature
  • Enhancement
  • Documentation update
  • Refactor
  • Other (please specify)

Checklist

  • My pull request has a clear title and description.
  • I have used semantic commit messages.
    Examples: "fix: Fixed foobar bug", "feat(accounts): Added foobar feature".
  • I have added/updated the necessary documentation on README.md.
  • I have added appropriate test cases (if applicable) to ensure the changes are functioning correctly.

By submitting this pull request, I confirm that I have read and complied with the contribution guidelines of this project.

- Created simple tags instead of annotated tags.
- Removed creation of minor version 2-digit tag.
@aj3sh aj3sh added the bug Something isn't working label Aug 12, 2024
@aj3sh aj3sh requested review from subashcs and golesuman August 12, 2024 13:14
@aj3sh aj3sh linked an issue Aug 12, 2024 that may be closed by this pull request
@aj3sh aj3sh merged commit dffb36b into opensource-nepal:main Aug 15, 2024
3 checks passed
@github-actions github-actions bot mentioned this pull request Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: use specific version in hook
2 participants