Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in How to use it #42

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jschoone
Copy link

No description provided.

Copy link

@garloff garloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@SebastianGode
Copy link
Member

recheck

Copy link
Member

@Nils-Magnus Nils-Magnus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The upstream bug is a one-char typo. That LGTM.

However in the meantime five updates (see plugins/modules/github_org_repository.py) of a inherited class sneaked in and are apparently expect its attributes to be [] instead of None:

  • contexts
  • restrictions
  • teams
  • topics
    - users
2024-01-04 10:58:23.254052 | fedora-pod | ERROR: Found 5 validate-modules issue(s) which need to be resolved:
2024-01-04 10:58:23.254097 | fedora-pod | ERROR: plugins/modules/github_org_repository.py:0:0: doc-default-does-not-match-spec: Argument 'contexts' in argument_spec found in branch_protections -> required_status_checks defines default as (None) but documentation defines default as ([])
2024-01-04 10:58:23.254104 | fedora-pod | ERROR: plugins/modules/github_org_repository.py:0:0: doc-default-does-not-match-spec: Argument 'restrictions' in argument_spec found in branch_protections defines default as ({}) but documentation defines default as (None)
2024-01-04 10:58:23.254109 | fedora-pod | ERROR: plugins/modules/github_org_repository.py:0:0: doc-default-does-not-match-spec: Argument 'teams' in argument_spec found in branch_protections -> required_pull_request_reviews -> dismissal_restrictions defines default as (None) but documentation defines default as ([])
2024-01-04 10:58:23.254115 | fedora-pod | ERROR: plugins/modules/github_org_repository.py:0:0: doc-default-does-not-match-spec: Argument 'topics' in argument_spec defines default as ([]) but documentation defines default as (None)
2024-01-04 10:58:23.254119 | fedora-pod | ERROR: plugins/modules/github_org_repository.py:0:0: doc-default-does-not-match-spec: Argument 'users' in argument_spec found in branch_protections -> required_pull_request_reviews -> dismissal_restrictions defines default as (None) but documentation defines default as ([])
2024-01-04 10:58:23.254124 | fedora-pod | See documentation for help: https://docs.ansible.com/ansible-core/2.16/dev_guide/testing/sanity/validate-modules.html

@scoopex
Copy link
Contributor

scoopex commented Sep 27, 2024

Branch needs a update, @gtema repaired the eco-checks :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants