forked from rancher/terraform-provider-rancher2
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW]: Implement opentelekomcloud_config
for rancher2_machine_config_v2
#5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artem-lifshits
requested review from
anton-sidelnikov,
sgmv,
Persimmonboy and
vladimirvshivkov
April 2, 2024 13:41
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job
anton-sidelnikov
previously approved these changes
Apr 3, 2024
anton-sidelnikov
approved these changes
Apr 3, 2024
Build succeeded. ✔️ lint SUCCESS in 2m 59s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Added support for OpenTelekomCloud for
rancher2_machine_config_v2
resource.PR Checklist
Acceptance tests setup
Following minimal env vars are needed to run tests:
Acceptance Steps Performed
2024/04/02 14:42:11 Getting from https://rancher-test.XXXXXXXin/ping
2024/04/02 14:42:11 Time to get req: 219 ms
=== RUN TestAccRancher2MachineConfigV2Basic
--- PASS: TestAccRancher2MachineConfigV2Basic (7.68s)
PASS
Process finished with the exit code 0