check getCurrentFuelPercent null value and drop NPE

opentripplanner · Jan 9, 2025 · 6778169 · 6778169
1 parent ff8411a
commit 6778169
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/...a/org/opentripplanner/updater/vehicle_rental/datasources/GbfsFreeVehicleStatusMapper.java b/...a/org/opentripplanner/updater/vehicle_rental/datasources/GbfsFreeVehicleStatusMapper.java
@@ -61,14 +61,16 @@ public VehicleRentalVehicle mapFreeVehicleStatus(GBFSBike vehicle) {
           : null;
       Ratio fuelPercent = null;
       try {
-        fuelPercent = new Ratio(vehicle.getCurrentFuelPercent());
+        if (vehicle.getCurrentFuelPercent() != null) {
+          fuelPercent = new Ratio(vehicle.getCurrentFuelPercent());
+        }
       } catch (IllegalArgumentException e) {
         LOG.warn(
           "Current fuel percent value not valid: {} - {}",
           vehicle.getCurrentFuelPercent(),
           e.getMessage()
         );
-      } catch (NullPointerException e) {}
+      }
       Distance rangeMeters = null;
       try {
         rangeMeters =