-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UCP/PROTO: Consider RNDV_PERF_DIFF #10401
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -403,6 +403,7 @@ static void ucp_proto_rndv_ctrl_variant_probe( | |
cfg_thresh = remote_proto->cfg_thresh; | ||
} | ||
|
||
ucp_proto_perf_apply_bias(perf, params->perf_bias); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. don't we need to apply it for RTS only? E.g. now it is applied for RTR as well making it more preferable than get_zcopy |
||
ucp_proto_select_add_proto(¶ms->super.super, cfg_thresh, cfg_priority, | ||
perf, rpriv, priv_size); | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -717,6 +717,45 @@ UCS_TEST_F(test_proto_perf, intersect_first) | |
expect_empty_range(5000, SIZE_MAX); | ||
} | ||
|
||
UCS_TEST_F(test_proto_perf, apply_zero_bias) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just wondering if it makes sense to add a mock test with |
||
m_perf = create(); | ||
add_func(0, SIZE_MAX, UCP_PROTO_PERF_FACTOR_LOCAL_TL, local_tl_func); | ||
add_func(0, SIZE_MAX, UCP_PROTO_PERF_FACTOR_REMOTE_TL, remote_tl_func); | ||
|
||
/* Apply zero bias */ | ||
ucp_proto_perf_apply_bias(m_perf.get(), 0); | ||
|
||
make_flat_perf(); | ||
print_perf(); | ||
|
||
expect_perf(0, SIZE_MAX, | ||
{{UCP_PROTO_PERF_FACTOR_LOCAL_TL, local_tl_func}, | ||
{UCP_PROTO_PERF_FACTOR_REMOTE_TL, remote_tl_func}}); | ||
} | ||
|
||
UCS_TEST_F(test_proto_perf, apply_bias) { | ||
m_perf = create(); | ||
add_func(0, SIZE_MAX, UCP_PROTO_PERF_FACTOR_LOCAL_TL, local_tl_func); | ||
add_func(0, SIZE_MAX, UCP_PROTO_PERF_FACTOR_REMOTE_TL, remote_tl_func); | ||
|
||
/* Apply 10% bias */ | ||
double bias = 0.1; | ||
ucp_proto_perf_apply_bias(m_perf.get(), bias); | ||
|
||
make_flat_perf(); | ||
print_perf(); | ||
|
||
/* Calculate expected */ | ||
auto bias_func = ucs_linear_func_make(0, 1 - bias); | ||
auto exp_local_tl_func = ucs_linear_func_compose(bias_func, local_tl_func); | ||
auto exp_remote_tl_func = ucs_linear_func_compose(bias_func, | ||
remote_tl_func); | ||
|
||
expect_perf(0, SIZE_MAX, | ||
{{UCP_PROTO_PERF_FACTOR_LOCAL_TL, exp_local_tl_func}, | ||
{UCP_PROTO_PERF_FACTOR_REMOTE_TL, exp_remote_tl_func}}); | ||
} | ||
|
||
UCS_TEST_F(test_proto_perf, intersect_last) | ||
{ | ||
/* | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems applying this bias leads to slightly different performance numbers and therefore breaks the mock test:
log1, log2, log3
Expected protocol:
{8247, 377094, "multi-frag copy-in"},
Actual protocol:
8247-363935 multi-frag copy-in
Could it be due to adding this bias? If so, we should update here the numbers in mock test as well