Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constraints file #2581

Merged
merged 20 commits into from
Apr 26, 2024
Merged

Constraints file #2581

merged 20 commits into from
Apr 26, 2024

Conversation

AlexanderDokuchaev
Copy link
Collaborator

Changes

  • Use constraints file to set versions of packages in one place
  • Depreciated message about installation extra requirements by pip install nncf[torch]
  • Fix System requirements of python version (actual python>=3.8)

Related tickets

134503

@AlexanderDokuchaev AlexanderDokuchaev requested a review from a team as a code owner March 16, 2024 20:10
@github-actions github-actions bot added documentation Improvements or additions to documentation NNCF TF Pull requests that updates NNCF TensorFlow NNCF PT Pull requests that updates NNCF PyTorch NNCF Common Pull request that updates NNCF Common NNCF OpenVINO Pull requests that updates NNCF OpenVINO NNCF ONNX Pull requests that updates NNCF ONNX NNCF PTQ Pull requests that updates NNCF PTQ labels Mar 16, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.06%. Comparing base (c8e1c21) to head (e548a99).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #2581       +/-   ##
============================================
- Coverage    91.20%   30.06%   -61.14%     
============================================
  Files          493      493               
  Lines        45540    45540               
============================================
- Hits         41535    13692    -27843     
- Misses        4005    31848    +27843

see 329 files with indirect coverage changes

Flag Coverage Δ
COMMON ?
ONNX ?
OPENVINO ?
TENSORFLOW 30.06% <ø> (ø)
TORCH ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 76.35% <ø> (-17.42%) ⬇️
torch 0.01% <ø> (-93.61%) ⬇️
tensorflow 93.74% <ø> (ø)
onnx 0.00% <ø> (-93.07%) ⬇️
openvino 0.00% <ø> (-94.19%) ⬇️
ptq 15.54% <ø> (-74.53%) ⬇️

@AlexanderDokuchaev AlexanderDokuchaev force-pushed the ad/constraints branch 2 times, most recently from 043b0a4 to ceef34c Compare March 16, 2024 22:06
@AlexanderDokuchaev AlexanderDokuchaev force-pushed the ad/constraints branch 2 times, most recently from b48e7bf to 76106a9 Compare March 19, 2024 22:21
@AlexanderDokuchaev AlexanderDokuchaev changed the title [WIP] Constraints file Constraints file Mar 20, 2024
@KodiaqQ
Copy link
Collaborator

KodiaqQ commented Mar 21, 2024

@AlexanderDokuchaev, do you have successful runs for the test_examples, conformance run (for a few models), and onnx e2e? Don't we need to run e2e's for PyTorch and Tensorflow as well?

@alexsu52 alexsu52 requested a review from MaximProshin March 22, 2024 06:21
@alexsu52
Copy link
Contributor

alexsu52 commented Mar 22, 2024 •
edited
Loading

@AlexanderDokuchaev I would recommend to present this approach on the technical sync.
cc '@MaximProshin.

@MaximProshin MaximProshin requested a review from AlexKoff88 March 22, 2024 06:36
@AlexanderDokuchaev
Copy link
Collaborator Author

manual/job/post_training_quantization/334
nightly/job/e2e_onnx_model_zoo/631
nightly/job/test_examples/313/

@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Apr 17, 2024
@AlexanderDokuchaev AlexanderDokuchaev force-pushed the ad/constraints branch 2 times, most recently from f8b55c9 to 32c751a Compare April 17, 2024 16:28
alexsu52
alexsu52 approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@alexsu52 alexsu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaximProshin
Copy link
Collaborator

@AlexanderDokuchaev , please also run SDL checks on this PR.

@AlexanderDokuchaev
Copy link
Collaborator Author

@MaximProshin sdl/job/nightly_trigger/129 - protex fails by not related issue

@MaximProshin
Copy link
Collaborator

sdl/job/nightly_trigger/129

we'll need to check Protex as well when it's recovered.

@alexsu52 alexsu52 mentioned this pull request Apr 24, 2024
Merged
@AlexanderDokuchaev
Copy link
Collaborator Author

@MaximProshin sdl/job/Protex_Scan_ABI/707/ -passed

@KodiaqQ KodiaqQ merged commit ad550e0 into openvinotoolkit:develop Apr 26, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KodiaqQ KodiaqQ KodiaqQ approved these changes

@MaximProshin MaximProshin MaximProshin approved these changes

@alexsu52 alexsu52 alexsu52 approved these changes

@AlexKoff88 AlexKoff88 Awaiting requested review from AlexKoff88

Assignees

@KodiaqQ KodiaqQ

Labels
NNCF Common Pull request that updates NNCF Common NNCF ONNX Pull requests that updates NNCF ONNX NNCF OpenVINO Pull requests that updates NNCF OpenVINO NNCF PT Pull requests that updates NNCF PyTorch NNCF PTQ Pull requests that updates NNCF PTQ NNCF TF Pull requests that updates NNCF TensorFlow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexanderDokuchaev @KodiaqQ @alexsu52 @MaximProshin