Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add int4 and int8 checks #2617

Merged
merged 5 commits into from
Apr 15, 2024
Merged

Conversation

DaniAffCH
Copy link
Contributor

Changes

This PR addresses #2565

  • Added a function to retrieve the number of int4 and int8 ops within the Weight Compression tests.
  • Added check to ensure that the number of int4 and int8 ops match the reference values
  • Added reference values for int4 and int8 ops

Related tickets

Ticket: 132562

Tests

Tested running:

pytest test_quantize_conformance.py::test_weight_compression[tinyllama_data_aware_awq_stateful_backend_OV] --data=

@DaniAffCH DaniAffCH requested a review from a team as a code owner April 5, 2024 15:16
@github-actions github-actions bot added the NNCF PTQ Pull requests that updates NNCF PTQ label Apr 5, 2024
@DaniAffCH
Copy link
Contributor Author

Unfortunately, my laptop memory was not enough to execute all the models to obtain the reference values. I could run only tinyllama_data_free_backend_OV as it is slightly lighter than the others.

I would appreciate it if you could run the remaining models, pointing out the reference values for num_int4 and num_int8 so I can add them to the reference.

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.93%. Comparing base (b134935) to head (785aad2).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #2617       +/-   ##
============================================
- Coverage    91.16%   77.93%   -13.23%     
============================================
  Files          494      494               
  Lines        45401    45401               
============================================
- Hits         41388    35382     -6006     
- Misses        4013    10019     +6006     

see 105 files with indirect coverage changes

Flag Coverage Δ
COMMON ?
ONNX ?
OPENVINO ?
TENSORFLOW 30.10% <ø> (ø)
TORCH 65.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 88.28% <ø> (-5.47%) ⬇️
torch 93.49% <ø> (-0.01%) ⬇️
tensorflow 93.74% <ø> (ø)
onnx 0.00% <ø> (-93.09%) ⬇️
openvino 25.70% <ø> (-68.47%) ⬇️
ptq 53.06% <ø> (-37.03%) ⬇️

Copy link
Contributor

@ljaljushkin ljaljushkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed some bug
references numbers are different for data-free, but test is passing and results file has different numbers
image

when run separately, results file has corrent numbers
image

@DaniAffCH
Copy link
Contributor Author

DaniAffCH commented Apr 11, 2024

Nice catch @ljaljushkin! I think the issue is fixed now

@andrey-churkin
Copy link
Contributor

@DaniAffCH Could you please rebase your branch to run CI one more time? Thanks.

@DaniAffCH
Copy link
Contributor Author

DaniAffCH commented Apr 15, 2024

Done, all the CI tests passed.

@ljaljushkin
Copy link
Contributor

image
44 build

@ljaljushkin ljaljushkin merged commit 60742a1 into openvinotoolkit:develop Apr 15, 2024
11 checks passed
@ljaljushkin
Copy link
Contributor

Thanks, @DaniAffCH! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NNCF PTQ Pull requests that updates NNCF PTQ
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants