-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add int4 and int8 checks #2617
add int4 and int8 checks #2617
Conversation
Unfortunately, my laptop memory was not enough to execute all the models to obtain the reference values. I could run only I would appreciate it if you could run the remaining models, pointing out the reference values for |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2617 +/- ##
============================================
- Coverage 91.16% 77.93% -13.23%
============================================
Files 494 494
Lines 45401 45401
============================================
- Hits 41388 35382 -6006
- Misses 4013 10019 +6006 see 105 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Lyalyushkin Nikolay <[email protected]>
Nice catch @ljaljushkin! I think the issue is fixed now |
@DaniAffCH Could you please rebase your branch to run CI one more time? Thanks. |
Done, all the CI tests passed. |
Thanks, @DaniAffCH! 🎉 |
Changes
This PR addresses #2565
Related tickets
Ticket: 132562
Tests
Tested running: