Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more hyperparams for EvolutionOptimizer #2618

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

UsingtcNower
Copy link
Contributor

Changes

Reason for changes

Related tickets

Tests

@UsingtcNower UsingtcNower requested a review from a team as a code owner April 6, 2024 14:01
@github-actions github-actions bot added the NNCF PT Pull requests that updates NNCF PyTorch label Apr 6, 2024
Copy link

codecov bot commented Apr 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.70%. Comparing base (7105e8c) to head (e703048).
Report is 12 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #2618       +/-   ##
============================================
- Coverage    91.16%   77.70%   -13.46%     
============================================
  Files          494      494               
  Lines        45389    45612      +223     
============================================
- Hits         41379    35443     -5936     
- Misses        4010    10169     +6159     
Files Coverage Δ
nncf/config/schemata/algo/filter_pruning.py 100.00% <100.00%> (ø)
nncf/config/schemata/defaults.py 100.00% <100.00%> (ø)
...runing/global_ranking/evolutionary_optimization.py 97.48% <100.00%> (+0.08%) ⬆️
...orch/pruning/filter_pruning/global_ranking/legr.py 100.00% <100.00%> (ø)

... and 120 files with indirect coverage changes

Flag Coverage Δ
COMMON ?
ONNX ?
OPENVINO ?
TENSORFLOW 30.10% <29.62%> (+<0.01%) ⬆️
TORCH 65.96% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 88.28% <ø> (-5.47%) ⬇️
torch 93.49% <100.00%> (+<0.01%) ⬆️
tensorflow 92.73% <ø> (-1.02%) ⬇️
onnx 0.00% <ø> (-93.10%) ⬇️
openvino 25.70% <ø> (-68.46%) ⬇️
ptq 53.06% <ø> (-37.07%) ⬇️

@UsingtcNower
Copy link
Contributor Author

@MaximProshin Could you please to help review this pr, or forward it to the appropriate reviewer? Thanks

Copy link
Contributor

@ljaljushkin ljaljushkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Please address one comment.

@UsingtcNower
Copy link
Contributor Author

Thanks for the contribution! Please address one comment.

Hi @ljaljushkin ,Thanks for your review! I've addressed the comment, Could you please help to check it?

@ljaljushkin
Copy link
Contributor

@UsingtcNower pre-commit-linters job is failing because of some issues with code style.
please fix it: https://github.com/openvinotoolkit/nncf/blob/develop/CONTRIBUTING.md#code-style

@UsingtcNower
Copy link
Contributor Author

@UsingtcNower pre-commit-linters job is failing because of some issues with code style. please fix it: https://github.com/openvinotoolkit/nncf/blob/develop/CONTRIBUTING.md#code-style

Hi @ljaljushkin Thanks for your review! I've reformat the code, could you please help to check it? BTW, I found the check tool also pointed out a code outside this change, so I'm not sure whether I need submit it or not.

@ljaljushkin
Copy link
Contributor

@UsingtcNower pre-commit-linters job is failing because of some issues with code style. please fix it: https://github.com/openvinotoolkit/nncf/blob/develop/CONTRIBUTING.md#code-style

Hi @ljaljushkin Thanks for your review! I've reformat the code, could you please help to check it? BTW, I found the check tool also pointed out a code outside this change, so I'm not sure whether I need submit it or not.

Feel free to submit all diff after make pre-commit run.
on our practice, it affects only modified files.

@UsingtcNower
Copy link
Contributor Author

UsingtcNower commented Apr 16, 2024

@UsingtcNower pre-commit-linters job is failing because of some issues with code style. please fix it: https://github.com/openvinotoolkit/nncf/blob/develop/CONTRIBUTING.md#code-style

Hi @ljaljushkin Thanks for your review! I've reformat the code, could you please help to check it? BTW, I found the check tool also pointed out a code outside this change, so I'm not sure whether I need submit it or not.

Feel free to submit all diff after make pre-commit run. on our practice, it affects only modified files.

Got it. @ljaljushkin Thanks for your patience in explaining it. I've verified "make pre-commit" all passed locally, could you please help to check it?

@ljaljushkin ljaljushkin merged commit 573b0c3 into openvinotoolkit:develop Apr 16, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NNCF PT Pull requests that updates NNCF PyTorch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants