-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more hyperparams for EvolutionOptimizer #2618
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2618 +/- ##
============================================
- Coverage 91.16% 77.70% -13.46%
============================================
Files 494 494
Lines 45389 45612 +223
============================================
- Hits 41379 35443 -5936
- Misses 4010 10169 +6159
... and 120 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@MaximProshin Could you please to help review this pr, or forward it to the appropriate reviewer? Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! Please address one comment.
Hi @ljaljushkin ,Thanks for your review! I've addressed the comment, Could you please help to check it? |
@UsingtcNower |
Hi @ljaljushkin Thanks for your review! I've reformat the code, could you please help to check it? BTW, I found the check tool also pointed out a code outside this change, so I'm not sure whether I need submit it or not. |
Feel free to submit all diff after |
Got it. @ljaljushkin Thanks for your patience in explaining it. I've verified "make pre-commit" all passed locally, could you please help to check it? |
Changes
Reason for changes
Related tickets
Tests