Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ruff version #2623

Merged
merged 9 commits into from
Apr 16, 2024
Merged

Update ruff version #2623

merged 9 commits into from
Apr 16, 2024

Conversation

kshpv
Copy link
Collaborator

@kshpv kshpv commented Apr 11, 2024

Changes

Update ruff version

Reason for changes

New useful rules

Related tickets

N/A

Tests

N/A

@kshpv kshpv requested a review from a team as a code owner April 11, 2024 12:04
@github-actions github-actions bot added NNCF TF Pull requests that updates NNCF TensorFlow NNCF PT Pull requests that updates NNCF PyTorch NNCF Common Pull request that updates NNCF Common experimental NNCF OpenVINO Pull requests that updates NNCF OpenVINO NNCF ONNX Pull requests that updates NNCF ONNX NNCF PTQ Pull requests that updates NNCF PTQ labels Apr 11, 2024
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.92%. Comparing base (7105e8c) to head (af25678).
Report is 9 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #2623       +/-   ##
============================================
- Coverage    91.16%   77.92%   -13.24%     
============================================
  Files          494      494               
  Lines        45389    45395        +6     
============================================
- Hits         41379    35376     -6003     
- Misses        4010    10019     +6009     
Files Coverage Δ
nncf/common/sparsity/schedulers.py 98.63% <100.00%> (ø)
...xperimental/common/tensor_statistics/collectors.py 88.52% <ø> (-4.45%) ⬇️
...perimental/torch/nas/bootstrapNAS/search/search.py 80.36% <100.00%> (-0.12%) ⬇️
...ental/torch/nas/bootstrapNAS/training/scheduler.py 92.59% <100.00%> (-0.11%) ⬇️
.../experimental/torch/sparsity/movement/scheduler.py 99.37% <100.00%> (ø)
nncf/tensorflow/graph/converter.py 95.23% <100.00%> (-0.03%) ⬇️
nncf/torch/nested_objects_traversal.py 94.69% <100.00%> (ø)
nncf/torch/quantization/algo.py 95.93% <100.00%> (ø)
...ncf/torch/quantization/precision_init/hawq_init.py 94.44% <ø> (ø)

... and 115 files with indirect coverage changes

Flag Coverage Δ
COMMON ?
ONNX ?
OPENVINO ?
TENSORFLOW 30.10% <15.38%> (+<0.01%) ⬆️
TORCH 65.95% <92.30%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 88.28% <100.00%> (-5.47%) ⬇️
torch 93.49% <100.00%> (-0.01%) ⬇️
tensorflow 93.74% <100.00%> (-0.01%) ⬇️
onnx 0.00% <ø> (-93.10%) ⬇️
openvino 25.70% <ø> (-68.46%) ⬇️
ptq 53.06% <ø> (-37.07%) ⬇️

examples/torch/common/utils.py Outdated Show resolved Hide resolved
@@ -17,7 +17,7 @@ repos:

- repo: https://github.com/astral-sh/ruff-pre-commit
# Ruff version.
rev: v0.1.3
rev: v0.3.5
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide short summary about new rules.
I'm not sure that we should enable all of them.

Copy link
Collaborator Author

@kshpv kshpv Apr 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New rules that the current code violates:
SIM401 👍
E721 👍
E266 👍
SIM113 👍
E262 👍
F841 👍
SIM910 👍
E265 👍
E251 👎 (covered by black)
E201 👎 (covered by black)
E231 👎 (covered by black)
E203 👎 (covered by black)
SIM103 👎(there are bad practises)

nncf/experimental/common/tensor_statistics/collectors.py Outdated Show resolved Hide resolved
tests/torch/qat/test_qat_segmentation.py Outdated Show resolved Hide resolved
tests/torch/sparsity/magnitude/test_algo.py Show resolved Hide resolved
@github-actions github-actions bot removed the NNCF PTQ Pull requests that updates NNCF PTQ label Apr 12, 2024
@KodiaqQ KodiaqQ merged commit 9efb6d3 into openvinotoolkit:develop Apr 16, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
experimental NNCF Common Pull request that updates NNCF Common NNCF ONNX Pull requests that updates NNCF ONNX NNCF OpenVINO Pull requests that updates NNCF OpenVINO NNCF PT Pull requests that updates NNCF PyTorch NNCF TF Pull requests that updates NNCF TensorFlow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants