Revert inheritance of QuantizationScheme from StrEnum #2629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PT nightly test build 184 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2629 +/- ##
============================================
- Coverage 91.20% 77.93% -13.28%
============================================
Files 494 494
Lines 45621 45401 -220
============================================
- Hits 41609 35382 -6227
- Misses 4012 10019 +6007
... and 108 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
KodiaqQ
approved these changes
Apr 15, 2024
KodiaqQ
pushed a commit
that referenced
this pull request
Apr 15, 2024
Copy of #2629 to release branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Do not inherit
QuantizationSchemefromStrEnumReason for changes
Fix degradation introduced in #2624