Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Torch] Check input_port_id in __eq__ of PTTargetPoint #2632

Conversation

daniil-lyakhov
Copy link
Collaborator

@daniil-lyakhov daniil-lyakhov commented Apr 15, 2024

Changes

Check input_port_id in eq of PTTargetPoins

Reason for changes

To correctly check PTTargetPoints

@daniil-lyakhov daniil-lyakhov requested a review from a team as a code owner April 15, 2024 13:57
@github-actions github-actions bot added the NNCF PT Pull requests that updates NNCF PyTorch label Apr 15, 2024
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.93%. Comparing base (60742a1) to head (3a7c5c7).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #2632       +/-   ##
============================================
- Coverage    91.16%   77.93%   -13.23%     
============================================
  Files          494      494               
  Lines        45401    45401               
============================================
- Hits         41388    35382     -6006     
- Misses        4013    10019     +6006     
Files Coverage Δ
nncf/torch/graph/transformations/commands.py 98.85% <ø> (ø)

... and 105 files with indirect coverage changes

Flag Coverage Δ
COMMON ?
ONNX ?
OPENVINO ?
TENSORFLOW 30.10% <ø> (ø)
TORCH 65.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 88.28% <ø> (-5.47%) ⬇️
torch 93.49% <ø> (-0.01%) ⬇️
tensorflow 93.74% <ø> (ø)
onnx 0.00% <ø> (-93.09%) ⬇️
openvino 25.70% <ø> (-68.47%) ⬇️
ptq 53.06% <ø> (-37.03%) ⬇️

@AlexanderDokuchaev AlexanderDokuchaev merged commit 4279929 into openvinotoolkit:develop Apr 15, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NNCF PT Pull requests that updates NNCF PyTorch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants