Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PT] Remove replace_custom_modules function #2732

Conversation

AlexanderDokuchaev
Copy link
Collaborator

Changes

Remove replace_custom_modules function

Reason for changes

After #2461, function is not actual.

@AlexanderDokuchaev AlexanderDokuchaev requested a review from a team as a code owner June 12, 2024 13:48
@github-actions github-actions bot added NNCF PT Pull requests that updates NNCF PyTorch experimental labels Jun 12, 2024
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.70%. Comparing base (65c9515) to head (ae7c7b3).
Report is 7 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2732      +/-   ##
===========================================
- Coverage    47.90%   47.70%   -0.20%     
===========================================
  Files          486      483       -3     
  Lines        46831    46305     -526     
===========================================
- Hits         22433    22090     -343     
+ Misses       24398    24215     -183     

see 39 files with indirect coverage changes

Flag Coverage Δ
COMMON 42.14% <ø> (-0.42%) ⬇️
ONNX 34.22% <ø> (-0.10%) ⬇️
OPENVINO 40.81% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 69.32% <ø> (-0.30%) ⬇️
torch 33.05% <ø> (-0.14%) ⬇️
tensorflow 0.00% <ø> (ø)
onnx 93.06% <ø> (+<0.01%) ⬆️
openvino 94.45% <ø> (+0.05%) ⬆️
ptq 80.97% <ø> (+0.05%) ⬆️

Copy link
Contributor

@alexsu52 alexsu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexanderDokuchaev AlexanderDokuchaev merged commit d06b174 into openvinotoolkit:develop Jun 12, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
experimental NNCF PT Pull requests that updates NNCF PyTorch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants