Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make NNCF common tensor statistics code pass mypy checks #2865

Merged
merged 44 commits into from
Aug 30, 2024
Merged

Make NNCF common tensor statistics code pass mypy checks #2865

merged 44 commits into from
Aug 30, 2024

Conversation

rk119
Copy link
Contributor

@rk119 rk119 commented Aug 2, 2024

Changes

General:

  • Added the target code path nncf/common/tensor_statistics to .mypy.ini.
  • Fixed mypy errors caused by type inconsistencies.

Used # type:ignore in the following cases:

  • has no attribute
  • incompatible types that couldn't be resolved without substantial code changes.

Related tickets

Closes Issue #2493

Tests

To validate that the changes did not affect the codebase, some pytest tests were run.

@rk119 rk119 requested a review from a team as a code owner August 2, 2024 11:13
@github-actions github-actions bot added the NNCF Common Pull request that updates NNCF Common label Aug 2, 2024
@rk119 rk119 mentioned this pull request Aug 2, 2024
Closed
@alexsu52 alexsu52 requested a review from daniil-lyakhov August 5, 2024 12:44
@daniil-lyakhov daniil-lyakhov self-assigned this Aug 5, 2024
daniil-lyakhov
daniil-lyakhov requested changes Aug 5, 2024
View reviewed changes
nncf/common/tensor_statistics/collectors.py Outdated Show resolved Hide resolved
nncf/common/tensor_statistics/collectors.py Outdated Show resolved Hide resolved
nncf/common/tensor_statistics/collectors.py Outdated Show resolved Hide resolved
nncf/common/tensor_statistics/collectors.py Outdated Show resolved Hide resolved
nncf/common/tensor_statistics/collectors.py Outdated Show resolved Hide resolved
nncf/common/tensor_statistics/statistic_point.py Show resolved Hide resolved
nncf/common/tensor_statistics/statistic_point.py Show resolved Hide resolved
nncf/common/tensor_statistics/statistics.py Outdated Show resolved Hide resolved
nncf/common/tensor_statistics/statistics.py Outdated Show resolved Hide resolved
nncf/common/tensor_statistics/statistics.py Outdated Show resolved Hide resolved
rk119 and others added 10 commits August 6, 2024 10:25
@rk119 @daniil-lyakhov
Update nncf/common/tensor_statistics/collectors.py
842339d 
Co-authored-by: Daniil Lyakhov <[email protected]>
@rk119 @daniil-lyakhov
Update nncf/common/tensor_statistics/collectors.py
7365a1a 
Co-authored-by: Daniil Lyakhov <[email protected]>
@rk119 @daniil-lyakhov
Update nncf/common/tensor_statistics/collectors.py
f73a829 
Co-authored-by: Daniil Lyakhov <[email protected]>
@rk119 @daniil-lyakhov
Update nncf/common/tensor_statistics/collectors.py
b64285d 
Co-authored-by: Daniil Lyakhov <[email protected]>
@rk119 @daniil-lyakhov
Update nncf/common/tensor_statistics/statistic_point.py
036c29e 
Co-authored-by: Daniil Lyakhov <[email protected]>
@rk119 @daniil-lyakhov
Update nncf/common/tensor_statistics/statistics.py
df384ad 
Co-authored-by: Daniil Lyakhov <[email protected]>
@rk119 @daniil-lyakhov
Update nncf/common/tensor_statistics/statistics.py
e7e285b 
Co-authored-by: Daniil Lyakhov <[email protected]>
@rk119 @daniil-lyakhov
Update nncf/common/tensor_statistics/statistics.py
7463e2e 
Co-authored-by: Daniil Lyakhov <[email protected]>
@rk119
Merge branch 'openvinotoolkit:develop' into develop
c0ea203
@rk119
Update
e81c686
daniil-lyakhov
daniil-lyakhov requested changes Aug 6, 2024
View reviewed changes
nncf/common/tensor_statistics/collectors.py Outdated Show resolved Hide resolved
nncf/common/tensor_statistics/collectors.py Outdated Show resolved Hide resolved
nncf/common/tensor_statistics/statistics.py Outdated Show resolved Hide resolved
nncf/common/tensor_statistics/statistics.py Outdated Show resolved Hide resolved
nncf/common/tensor_statistics/statistics.py Outdated Show resolved Hide resolved
nncf/common/tensor_statistics/statistics.py Outdated Show resolved Hide resolved
nncf/common/tensor_statistics/statistic_point.py Outdated Show resolved Hide resolved
@rk119
Copy link
Contributor Author

rk119 commented Aug 9, 2024

Hi @daniil-lyakhov, when you have a moment, could you please review the comments I've added for the requested changes? Thank you!

@daniil-lyakhov daniil-lyakhov self-requested a review August 12, 2024 08:35
@rk119
Copy link
Contributor Author

rk119 commented Aug 13, 2024

@daniil-lyakhov

daniil-lyakhov
daniil-lyakhov reviewed Aug 20, 2024
View reviewed changes
nncf/common/tensor_statistics/statistics.py Outdated Show resolved Hide resolved
nncf/common/tensor_statistics/statistics.py Outdated Show resolved Hide resolved
nncf/common/tensor_statistics/statistics.py Outdated Show resolved Hide resolved
nncf/common/tensor_statistics/statistics.py Outdated Show resolved Hide resolved
nncf/common/tensor_statistics/statistics.py Outdated Show resolved Hide resolved
nncf/common/tensor_statistics/statistics.py Outdated Show resolved Hide resolved
@daniil-lyakhov
Copy link
Collaborator

@AlexanderDokuchaev, please merge

@alexsu52 alexsu52 merged commit ff967e8 into openvinotoolkit:develop Aug 30, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniil-lyakhov daniil-lyakhov daniil-lyakhov approved these changes

Assignees

@daniil-lyakhov daniil-lyakhov

Labels
NNCF Common Pull request that updates NNCF Common
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rk119 @daniil-lyakhov @alexsu52