Fix redis events outbound transit #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jamshale <[email protected]>
Signed-off-by: jamshale <[email protected]>
jamshale
force-pushed
the
feat/32-fix-redis-outbound
branch
from
2d1983d to
daa04ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After getting more familiar with the plugin and how to test it I realized that the outbound transit wasn't working. It was related to child RedisOutboundQueue class having a
wire_formatparameter that caused a an error in acapyaries_cloudagent/transport/outbound/manager.py-->TypeError: __init__() missing 1 required positional argument: 'wire_format'.I fixed it by copying the http outbound transit in acapy. After which I could see connections becoming
activeand the relay and deliverer services working correctly. I still think this would benefit from more testing of some of the use cases but now at least all the services are tested correctly.