Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to continue on HTML rewriting issue #73

Merged
merged 5 commits into from
Nov 19, 2024

Rename flag to --html-issues-warn-only

e22e348
Select commit
Loading
Failed to load commit list.
Merged

Add flag to continue on HTML rewriting issue #73

Rename flag to --html-issues-warn-only
e22e348
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 19, 2024 in 0s

43.85% (-0.01%) compared to f3d6b9a

View this Pull Request on Codecov

43.85% (-0.01%) compared to f3d6b9a

Details

Codecov Report

Attention: Patch coverage is 40.00000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 43.85%. Comparing base (f3d6b9a) to head (e22e348).

Files with missing lines Patch % Lines
scraper/src/mindtouch2zim/html_rewriting.py 35.29% 9 Missing and 2 partials ⚠️
scraper/src/mindtouch2zim/processor.py 50.00% 2 Missing ⚠️
scraper/src/mindtouch2zim/client.py 50.00% 1 Missing ⚠️
scraper/src/mindtouch2zim/entrypoint.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
- Coverage   43.86%   43.85%   -0.01%     
==========================================
  Files          15       15              
  Lines         953      969      +16     
  Branches      131      133       +2     
==========================================
+ Hits          418      425       +7     
- Misses        522      529       +7     
- Partials       13       15       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features: