Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance assets processing reliability and logs #96

Merged
merged 1 commit into from
Dec 6, 2024

Catch all exception on bad asset processing, and log full details abo…

de9e0ee
Select commit
Loading
Failed to load commit list.
Merged

Enhance assets processing reliability and logs #96

Catch all exception on bad asset processing, and log full details abo…
de9e0ee
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 6, 2024 in 0s

49.20% (-0.23%) compared to 1399a4a

View this Pull Request on Codecov

49.20% (-0.23%) compared to 1399a4a

Details

Codecov Report

Attention: Patch coverage is 18.18182% with 27 lines in your changes missing coverage. Please review.

Project coverage is 49.20%. Comparing base (1399a4a) to head (de9e0ee).

Files with missing lines Patch % Lines
scraper/src/mindtouch2zim/processor.py 6.25% 15 Missing ⚠️
scraper/src/mindtouch2zim/asset.py 25.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #96      +/-   ##
==========================================
- Coverage   49.42%   49.20%   -0.23%     
==========================================
  Files          17       17              
  Lines        1050     1063      +13     
  Branches      147      149       +2     
==========================================
+ Hits          519      523       +4     
- Misses        520      529       +9     
  Partials       11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.