Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from multiple --tag flags to one single --tags flag #315

Open
benoit74 opened this issue May 13, 2024 · 3 comments
Open

Move from multiple --tag flags to one single --tags flag #315

benoit74 opened this issue May 13, 2024 · 3 comments

Comments

@benoit74
Copy link
Collaborator

Currently, when the user wants to specify multiple ZIM tags, he has to specify multiple time the --tag parameter like in sotoki --tag "Quality Assurance" --tag "Another TAG"

This kind of this is not supported by the Zimfarm and is not in line with other scrapers behavior.

We hence want to move to one single --tags flag which might contain a CSV value like in sotoki --tags "Quality Assurance,Another TAG". Commas are not expected to be used in tag values.

NOTA: this is a breaking API change ... but I'm not sure this is really widely used anyway, so I suggest to still make it into 2.2.0 (instead of creating a 3.0.0).

@rgaudin
Copy link
Member

rgaudin commented May 13, 2024

As much as I don't like it, we made a promise in CHANGELOG that we'd respect semantic versioning so 3.0.0

@rgaudin
Copy link
Member

rgaudin commented May 13, 2024

Please don't use CSV, we already have ; separated in the ZIM. Makes more sense to use the same format.

@benoit74
Copy link
Collaborator Author

OK, let's go for 3.0.0 and ; then 😉

@kelson42 kelson42 modified the milestones: 3.0.0, 2.2.0 May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants