-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grpc changes, model conversion, validation #1161
grpc changes, model conversion, validation #1161
Conversation
17f4672
to
4693570
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1161 +/- ##
==========================================
- Coverage 53.76% 53.32% -0.45%
==========================================
Files 108 108
Lines 10237 10337 +100
==========================================
+ Hits 5504 5512 +8
- Misses 3755 3841 +86
- Partials 978 984 +6
☔ View full report in Codecov by Sentry. |
4693570
to
3c741ed
Compare
3c741ed
to
731c5f6
Compare
0929bc3
to
1c9bbc6
Compare
c0757aa
to
9673f6c
Compare
9673f6c
to
c3cef29
Compare
c3cef29
to
48ac6a6
Compare
I think this looks good to me implementation-wise. What are you thinking re: tests? |
48ac6a6
to
4f366a6
Compare
Tracked in #1163 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: everettraven, grokspawn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Jordan Keister <[email protected]>
4f366a6
to
26a9f82
Compare
/lgtm |
f7c6429
into
operator-framework:master
Description of the change:
Contributes to #1154
NB: this is declarativeconfig --> grpc path only, right now. We need future issues for
Motivation for the change:
Reviewer Checklist
/docs