ref #4392 - fix squid black list not showing categories

[abonanni]

Resolve #4392

[AdSchellevis]

I don't think a configd action named blacklist exists.... easy to try using configctl blacklist categories list on a console. These %s.index files are created as a result from the download, triggered by fetchACLs.py:

plugins/www/squid/src/opnsense/service/conf/actions.d/actions_proxy.conf

Lines 54 to 70 in 30dd742

	[fetchacls]
	command:
	/usr/local/bin/flock -n -E 0 -o /tmp/fetchACLs.lock /usr/local/opnsense/scripts/proxy/fetchACLs.py && (
	/usr/local/sbin/pluginctl -c webproxy reload;
	/usr/local/etc/rc.d/squid reload
	)
	parameters:
	type:script
	message:download and reload proxy ACLs from remote locations
	description:Download and reload external proxy ACLs
	[downloadacls]
	command:/usr/local/bin/flock -n -E 0 -o /tmp/fetchACLs.lock /usr/local/opnsense/scripts/proxy/fetchACLs.py
	parameters:
	type:script
	message:download proxy ACLs from remote locations
	description:Download external proxy ACLs

plugins/www/squid/src/opnsense/scripts/proxy/fetchACLs.py

Line 357 in 30dd742

with open('%s.index' % target_filename, 'w', buffering=10240) as idx_out:

[abonanni]

Ok but if "ConfigdPopulateAct" is not set, the list is not populated.

In file /usr/local/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/JsonKeyValueStoreField.php line 126 :
if (!empty($this->internalConfigdPopulateAct)) { code populate list only if variable internalConfigdPopulateAct is not empty.

So set this variable in XML makes the code working.

A better solution would perhaps be to correct the file /usr/local/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/JsonKeyValueStoreField.php.

[AdSchellevis]

@abonanni it looks like a regression in opnsense/core@525481c, previously a callout was not required. If you open a ticket in core, I'll take a look.