security/acme-client: Add support for mijn.host DNS challenge #4446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fraenki
requested changes
Jan 6, 2025
security/acme-client/src/opnsense/mvc/app/models/OPNsense/AcmeClient/AcmeClient.xml
Outdated
Show resolved
Hide resolved
...ty/acme-client/src/opnsense/mvc/app/library/OPNsense/AcmeClient/LeValidation/DnsMijnHost.php
Outdated
Show resolved
Hide resolved
...ty/acme-client/src/opnsense/mvc/app/library/OPNsense/AcmeClient/LeValidation/DnsMijnHost.php
Outdated
Show resolved
Hide resolved
...ty/acme-client/src/opnsense/mvc/app/library/OPNsense/AcmeClient/LeValidation/DnsMijnHost.php
Outdated
Show resolved
Hide resolved
|
Please note: this can only be merged when a new release of acme.sh is available that contains the new mijnhost dnsapi. |
fraenki
changed the title
- alphabetic order maintained in security/acme-client/src/opnsense/mvc/app/controllers/OPNsense/AcmeClient/forms/dialogValidation.xml - file renamed - Class renamed to DnsMijnhost and copyright corrected in security/acme-client/src/opnsense/mvc/app/models/OPNsense/AcmeClient/AcmeClient.xml
|
Thx for the quick review! Changes made as requested. |
fraenki
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for mijn.host DNS challenge was merged into dev for acme.sh. Once released, this pull request adds support for mijn.host to the acme client plugin. Not sure how timing of this is supposed to work, but here you go.