dns/ddclient: empty ip send to dns provider & replace dyndns by dynu #4448
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important notices
Before you add a new report, we ask you kindly to acknowledge the following:
Describe the bug
The current service to lookup external ip ( https://github.com/opnsense/plugins/blob/master/dns/ddclient/src/opnsense/scripts/ddclient/lib/address.py#L35) for dyndns times out (and has been doing so for ages):
Subsequently no IP is displayed in GUI and no IP is send to the DNS provider.
The PR resolves two issues following this.
The lookup returns no parse ip and extract_address returns and empty string. excute only checks for None, hence an empty string was passed to dns provider.
Following the change, a proper error message is displayed in the log files and more importantly it stops the dns update.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
DDNS lookup and population of IP working in GUI.
Screenshots
If applicable, add screenshots to help explain your problem.
Relevant log files
If applicable, information from log files supporting your claim.
Additional context
Add any other context about the problem here.
Environment
Software version used and hardware type if relevant.
e.g.:
OPNsense 24.7.11_2-amd64
Plugin: os-ddclient (installed) 1.26