Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update some elements in BOM #737

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

goalaleo
Copy link

@goalaleo goalaleo commented Dec 26, 2024

Changes

  • Update Source 1 link for top-camera and bottom-camera as it was still pointing to the v2/v3 camera store page.
  • Add note for nozzle-rack to print it in white or light color filament as instructed in the printing parts documentation

Why

  • Reduce likelyhood or a DIYer ordering the wrong camera when sourcing based on the bom_v4.0.0.html file
  • Reduce likelyhood or printing the nozzle-rack in dark color

Screenshot 2025-01-14 at 14 49 03

BEFORE: https://www.opulo.io/products/openpnp-usb-camera-set
Screenshot 2024-12-27 at 0 54 18

AFTER: https://www.opulo.io/products/lumenpnp-v4-camera-set
Screenshot 2024-12-27 at 0 57 51

`top-camera` and `bottom-camera` still contained links to old v2/v3 camera set in opulo store. This commit updates the links to point to the v4 camera page.
@goalaleo goalaleo changed the title Update v4 camera link in bom Update some elements in BOM Dec 31, 2024
@goalaleo
Copy link
Author

@lucian151 @sphawes what would be the correct way to contribute to this repo as an outsider? I read the Making a Contribution section of the contributing doc, and based on it setting main as the base branch is not the way to go, but then there's this guideline

Individual contributors make changes in their forks, and merge them into the main repo's feature branch. Once the feature branch is done, it's then merged into master once it's complete

I can't create branches in the main repo, so then the question becomes: which feature branch in the main repo should I use, or should I ask one to be created? Or, for exampe, should one be automatically created for the next patch version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant