Added check for egress rule to allow traffic on all ports in MS NSG. #300
Conversation
oracle-contributor-agreement
bot
added
the
OCA Verified
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA). To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
oracle-contributor-agreement
bot
added
OCA Required
ManviGupta-prog
force-pushed
the
topic_manvigup-JCS-14691
branch
from
1c0ae26 to
6f73111
Compare
oracle-contributor-agreement
bot
added
OCA Verified
|
Can you explain how you tested check_egress_all_traffic_in_seclist_or_nsg() function? The reason I find this important is that if I look at this code submission only the "nsg" option would ever be passed to this function. |
| continue | ||
| fi | ||
|
|
||
| if [[ $egress_destination == "0.0.0.0/0" && ( $egress_protocol == "all" || $egress_protocol == "1" ) ]]; then |
There was a problem hiding this comment.
It would be nice if the "1" was assigned to a descriptive variable. In other parts of the code a variable is defined for tcp_protocol="6". This tells a reader of the code that TCP is being looked for when $tcp_protocol is referenced. I am reading this and I have no clue what "1" protocol is.
No description provided.