Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add hmstr #340

Merged
merged 3 commits into from
Sep 26, 2024
Merged

Feat/add hmstr #340

merged 3 commits into from
Sep 26, 2024

Conversation

trung2891
Copy link
Member

@trung2891 trung2891 commented Sep 26, 2024

Summary by CodeRabbit

  • New Features
    • Updated the version of the @oraichain/oraidex-common package to 1.1.21.
    • Modified the factory address associated with the HMSTR token on the Oraichain network.

@trung2891 trung2891 requested a review from haunv3 September 26, 2024 10:14
Copy link

coderabbitai bot commented Sep 26, 2024

Walkthrough

The pull request includes an update to the version number of the @oraichain/oraidex-common package in the package.json file, incrementing it from 1.1.20 to 1.1.21. Additionally, the constant HMSTR_ORAICHAIN_DENOM in the constant.ts file has been modified to reflect a new factory address associated with the HMSTR token on the Oraichain network.

Changes

File Change Summary
packages/oraidex-common/package.json Version updated from 1.1.20 to 1.1.21.
packages/oraidex-common/src/constant.ts Constant HMSTR_ORAICHAIN_DENOM updated from "factory/orai17hyr3eg92..." to "factory/orai1wuvhex9xqs3...".

Possibly related PRs

  • Feat/add cw20 ton #312: Updates the HMSTR_ORAICHAIN_DENOM constant in constant.ts, directly related to the changes made in this PR.
  • Feat/add hmstr #339: Involves the addition of the HMSTR_ORAICHAIN_DENOM constant in constant.ts, connected to the modifications in this PR.

Suggested reviewers

  • trungbach

Poem

🐇 In the code where constants play,
A new address hops in today!
Version numbers rise with cheer,
For HMSTR, the path is clear.
With every change, we grow and thrive,
In the world of code, we come alive! 🌟


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 6cfdced and f940952.

📒 Files selected for processing (2)
  • packages/oraidex-common/package.json (1 hunks)
  • packages/oraidex-common/src/constant.ts (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • packages/oraidex-common/package.json
🔇 Additional comments (1)
packages/oraidex-common/src/constant.ts (1)

103-103: LGTM. Verify the new factory address and check for other occurrences.

The update to the HMSTR_ORAICHAIN_DENOM constant looks good and aligns with the PR objective of adding HMSTR support. However, please ensure the following:

  1. Verify that the new factory address orai1wuvhex9xqs3r539mvc6mtm7n20fcj3qr2m0y9khx6n5vtlngfzes3k0rq9 is correct for the HMSTR token on the Oraichain network.
  2. Check if there are any other occurrences of the old factory address orai17hyr3eg92fv34fdnkend48scu32hn26gqxw3hnwkfy904lk9r09qqzty42 in the codebase that might need to be updated as well.

To check for other occurrences of the old factory address, you can run the following command:

This will help ensure that all references to the HMSTR token's factory address are updated consistently across the project.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@trung2891 trung2891 merged commit 6c9bb3b into main Sep 26, 2024
3 of 4 checks passed
@trung2891 trung2891 deleted the feat/add-hmstr branch September 26, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants