Offers

[raphjaph]

Tested in this tx: https://mempool.space/tx/78ccdf1ee2bf14f36e83653a99586329b2931a17f786ffa8e6e0b79650d2bc40

[casey]

@lifofifoX This is finally done! Have a look over it, especially at tests and edge cases.

[lifofifoX]

@casey Looks great to me! Only potential issue I see is that accepting offer might error if the sat is reinscribed.

Other than that, it's nice that accepting offer isn't concerned with where the inscription is going. This way, it'd be compatible with offers created with one of the web wallets.

[casey]

@casey Looks great to me!

Dope.

Only potential issue I see is that accepting offer might error if the sat is reinscribed.

We'll definitely relax that in a follow up PR. Either by allowing any inscriptions on the same sat to be transferred, as long as one of them was passed to --inscription, or requiring --inscription multiple times, and requiring you pass it for all reinscriptions.

Probably the former. These days, ord is really a power-user tool, and I think we can expect users to understand that when inscriptions are on the same sat, they will always be transferred together.

In any case, we will also eventually allow --inscription to be passed multiple times, so you can accept an offer for any number of inscriptions, and provide an ord wallet offer view command, for viewing a PSBT offer and seeing what it would do if accepted, which inscriptions it's moving, where they go, and what the balance change would be.