Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .opus to audio types #4194

Merged
merged 3 commits into from
Jan 24, 2025
Merged

Add .opus to audio types #4194

merged 3 commits into from
Jan 24, 2025

Conversation

raphjaph
Copy link
Collaborator

@raphjaph raphjaph commented Jan 24, 2025 •
edited
Loading

@raphjaph raphjaph requested a review from casey January 24, 2025 16:55
casey
casey requested changes Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@casey casey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could actually use audio/ogg;codecs=opus. audio/ogg is the container format, not the codec, which is correct for .opus files, which use the ogg container, but since we know it's a .opus file, we can get more specific with audio/ogg;codecs=opus.

@raphjaph raphjaph requested a review from casey January 24, 2025 20:06
casey
casey approved these changes Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@casey casey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raphjaph raphjaph merged commit 75911cb into ordinals:master Jan 24, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@casey casey casey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raphjaph @casey