Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Feat/attribute object support #125

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jpower432
Copy link
Contributor

@jpower432 jpower432 commented Dec 16, 2022

Description

Adds the ability to specify attribute objects, and arrays through the DatasetConfiguration. Removes reflection and empty interfaces when reading the dataset configuration and descriptor annotations.

Fixes #80

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Unit tests added

How To Test Manually

TBD

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Requires updates to the Getting Started Guide

@jpower432 jpower432 marked this pull request as draft December 16, 2022 20:20
@jpower432 jpower432 force-pushed the feat/attribute-object-support branch 2 times, most recently from 9c93022 to 2cfd760 Compare January 12, 2023 23:42
BREAKING CHANGE: Attributes interface has been removed and AttributeSet interface has been modified

Signed-off-by: Jennifer Power <[email protected]>
Signed-off-by: Jennifer Power <[email protected]>
@jpower432 jpower432 force-pushed the feat/attribute-object-support branch from 2cfd760 to 1f6d46d Compare January 18, 2023 23:31
@jpower432 jpower432 mentioned this pull request Jan 20, 2023
9 tasks
Signed-off-by: Jennifer Power <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFE] Support attribute arrays and objects in the DataSetConfiguration
1 participant